Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of error records and their line numbers to PreviewResult #117

Open
muga opened this issue Mar 4, 2015 · 1 comment
Open

Add number of error records and their line numbers to PreviewResult #117

muga opened this issue Mar 4, 2015 · 1 comment
Labels
enhancement New feature or request

Comments

@muga
Copy link
Contributor

muga commented Mar 4, 2015

We should add more information to PreviewResult. Because we check the result of PreviewExecutor and often determine whether we should execute run command or not. The current PreviewResult provides schema and list of ignored exceptions for users. I think that it's better to add more:

  • of records that PreviewExecutor read.

  • of error records

  • actual error raw records and those line number (optional)

I also think that the above information can be build by using CommitReport on https://github.com/embulk/embulk/blob/master/embulk-core/src/main/java/org/embulk/exec/PreviewExecutor.java#L106

@muga
Copy link
Contributor Author

muga commented Mar 4, 2015

This ticket is related to ticket #46

@muga muga added the enhancement New feature or request label Mar 4, 2015
@frsyuki frsyuki changed the title Add more information to PreviewResult Add number of error records and their line numbers to PreviewResult Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant