Fix the mix-up of command line options -L and -I (Fix #1413)

[dmikurube]

We have had a bug in command line parsing -- -L and -I have been mixed up. (#1413)

[dmikurube]

@hiroyuki-sato Trying to fix #1413. Could you have a quick look?

[hiroyuki-sato]

@dmikurube Thanks! LGTM 👍

I checked those options behavior using embulk-parser-jsonpath.

git checkout -b topic/fix-mixup-of-cli-options-L-I upstream/fix-mixup-of-cli-options-L-I
./gradlew executableJar
./gradlew embulk-ruby:gemContents

cd path/to/embulk-parser-jsonpath
./gradlew gems

cd /path/to/embulk-parser-jsonpath

-L: option test.

/path/to/embulk/build/executable/embulk-0.10.30-SNAPSHOT.jar \
  -X embulk_home=/path/to/.embulk-dev \
  run  \
  -L build/gemContents \ # not contains lib
  -I path/to/embulk/embulk-ruby/build/gemContents/lib \
  example/conf.yml

-I: option test.

/path/to/embulk/build/executable/embulk-0.10.30-SNAPSHOT.jar \
  -X embulk_home=/path/to/.embulk-dev \
  run  \
  -I build/gemContents/lib \ # contains lib
  -I path/to/embulk/embulk-ruby/build/gemContents/lib \
  example/conf.yml

2021-04-07 20:24:39.469 +0900 [INFO] (main): embulk_home is set from command-line: /Users/user/.embulk-dev
2021-04-07 20:24:39.953 +0900 [INFO] (main): Started Embulk v0.10.30-SNAPSHOT
2021-04-07 20:24:42.654 +0900 [INFO] (0001:transaction): Gem's home and path are set by system configs "gem_home": "/Users/user/.embulk-dev/lib/gems", "gem_path": ""
2021-04-07 20:24:43.353 +0900 [INFO] (0001:transaction): Loaded plugin embulk/parser/jsonpath from a load path
2021-04-07 20:24:43.402 +0900 [INFO] (0001:transaction): Listing local files at directory 'example' filtering filename by prefix 'input'
2021-04-07 20:24:43.402 +0900 [INFO] (0001:transaction): "follow_symlinks" is set false. Note that symbolic links to directories are skipped.
2021-04-07 20:24:43.405 +0900 [INFO] (0001:transaction): Loading files [example/input.json, example/input3.json, example/input2.json]
2021-04-07 20:24:43.453 +0900 [INFO] (0001:transaction): Using local thread executor with max_threads=8 / output tasks 6 = input tasks 3 * 2
2021-04-07 20:24:43.464 +0900 [INFO] (0001:transaction): {done:  0 / 3, running: 0}
2021-04-07 20:24:43.536 +0900 [INFO] (0012:task-0000): JSONPath = $.results
2021-04-07 20:24:43.536 +0900 [INFO] (0014:task-0002): JSONPath = $.results
2021-04-07 20:24:43.537 +0900 [INFO] (0013:task-0001): JSONPath = $.results
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  2 / 3, running: 1}
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  3 / 3, running: 0}
2021-04-07 20:24:43.667 +0900 [INFO] (0001:transaction): {done:  3 / 3, running: 0}
2021-04-07 20:24:43.684 +0900 [INFO] (main): Committed.
2021-04-07 20:24:43.684 +0900 [INFO] (main): Next config diff: {"in":{"last_path":"example/input3.json"},"out":{}}

[shroman]

@hiroyuki-sato Thanks for verifying!

[himadieievsv]

lgtm

[dmikurube]

Thanks, all, for having a look! I'm going to release v0.10.30 with it soon.