Add support for unity host attach/detach unity lun

[crook]

Add support for unity host attach/detach unity lun

[jealous]

Hi @crook , the coverage dropped a little. It would be appreciated if you could remove the unused code or cover them with unit test. The detail data can be retrieved here:
https://coveralls.io/jobs/14804809
The main gap lies in the resource module.

[jealous]

These lines are duplicated.
I would suggest to create a property like this:

@properties
@instance_cache
def lun_ids(self):
    ret = []
    if self.host_luns:
        for host_lun in self.host_luns:
            if host_lun.lun:
                ret.append(host_lun.lun.id)
    return ret

def has_hlu(self, lun):
    return lun.id in self.lun_ids

The @instance_cache here works as an instance level memoize.

The code suggested here is a demonstration of the thoughts. Please try to converge the duplicated for loops.

[jealous]

Hi @crook ,
Nice work 👍. Very concise unit tests. Just some comments to be addressed.
And there is no need to open a new PR when you are done. I think just push your change will update this PR.

[coveralls]

Coverage decreased (-0.06%) to 92.06% when pulling b61284a on crook:master into 5d3ab6f on emc-openstack:develop.

[coveralls]

Coverage increased (+0.1%) to 92.243% when pulling 9c69181 on crook:master into 5d3ab6f on emc-openstack:develop.