[GH 58] Link aggregation #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tianqi-Tang
force-pushed
the
feature/GH-58-link-aggregation
branch
from
2e61fad
to
baf97e8
Compare
jealous
reviewed
Nov 21, 2016
| - label: macAddress | ||
| - label: isLinkUp | ||
| - label: parentStorageProcessor | ||
| converter: UnityStorageProcessor |
There was a problem hiding this comment.
Need an empty line at the end of the file.
jealous
reviewed
Nov 21, 2016
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Normally we format the json file with 2 space indent.
jealous
reviewed
Nov 21, 2016
| assert_that(la.supported_mtus, only_contains(1500, 9000)) | ||
|
|
||
| @patch_rest | ||
| def test_create(self): |
There was a problem hiding this comment.
Do we need a case for creation failed due to already exists?
Tianqi-Tang
force-pushed
the
feature/GH-58-link-aggregation
branch
from
baf97e8
to
b9d97af
Compare
jay-tsu
reviewed
Nov 21, 2016
| return cls(_id=resp.resource_id, cli=cli) | ||
|
|
||
| def modify(self, mtu=None, add_ports=None, remove_ports=None): | ||
| if mtu is None and not add_ports and not remove_ports: |
There was a problem hiding this comment.
The client should ensure at least one thing to modify. It may be not necessary to check here.
There was a problem hiding this comment.
That make sense. I have removed it. Thanks.
jay-tsu
reviewed
Nov 21, 2016
| addPorts=add_ports, | ||
| removePorts=remove_ports) | ||
| resp.raise_if_err() | ||
|
|
There was a problem hiding this comment.
The delete is implemented by the framework.
Support Link aggregation in storops
Tianqi-Tang
force-pushed
the
feature/GH-58-link-aggregation
branch
from
b9d97af
to
1f0a33b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link aggregation create/modify/delete support in storops.