Feature/gce driver #194
Merged
Feature/gce driver #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintkitson
force-pushed
the
feature/gce_driver
branch
from
99311ce
to
6a6960e
Compare
|
Nice job @ltouati. All tests are passing, and we will figure out when to merge this shortly. |
clintkitson
force-pushed
the
feature/gce_driver
branch
from
6a6960e
to
c800216
Compare
|
ok great thanks a lot |
clintkitson
force-pushed
the
feature/gce_driver
branch
2 times, most recently
from
d3c8e34
to
ec5e6dd
Compare
|
@akutz I believe we are good here now with pre-emption support. |
clintkitson
force-pushed
the
feature/gce_driver
branch
from
ec5e6dd
to
9d132d0
Compare
|
Driver now is fully functional including snapshots. |
This updates a few things relating to bugs found during initial testing and includes some features to minimize the configuration of the driver.
|
This cannot be merged until @clintonskitson updates his previous comment with the contextual and appropriate meme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a working GCE driver. Will look to update this PR when pre-emption is merged.