New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed logging not occuring with Ubuntu 14.04 #373
Conversation
This patch is a fix for issue #365, where the logging is not writing to /var/log/rexray/rexray.log. Since os.Stderr is attached to TTY(!log.IsTerminal()) rexray doesn't write to the log file so I removed cmd.StdErr.
Changes Unknown when pulling 7476ad5 on philippfranke:fix_logging into * on emccode:master*. |
Current coverage is
|
Hi @philippfranke, I'm not sure we want to do this. I based this detection on the same detection in logrus, which recently updated its logic. Additionally, this apparently only happens on Ubuntu 14.04, so unless this patch has been tested this on all other, supported distros, this patch won't be accepted that will have possible side-effects for other distributions. |
Definitely need to look into this one further. Thanks for the feedback so far and work towards a fix @philippfranke. |
@akutz I tested this and I believe the fix does in fact take care of the issue and doesn't seem to represent any detrimental issues. Your call. |
Hi @philippfranke / @clintonskitson, I can cherry-pick @philippfranke's fix or he can close and reopen this PR against the |
…ge_to_dell_emc_provider_support Changed EMC To Dell EMC
This patch is a fix for issue #365, where the logging is not writing
to
/var/log/rexray/rexray.log
.Since os.Stderr is attached to TTY(
!log.IsTerminal()
) rexray doesn'twrite to the log file so I removed
cmd.Stderr
.