Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native python implementation for NB-GLM instead of edgeR #2

Open
emdann opened this issue May 14, 2021 · 9 comments
Open

Native python implementation for NB-GLM instead of edgeR #2

emdann opened this issue May 14, 2021 · 9 comments

Comments

@emdann
Copy link
Owner

emdann commented May 14, 2021

Gathering some suggestions:

@MikeDMorgan
Copy link

tensorflow might be useful for GLMs: https://www.tensorflow.org/probability/examples/Generalized_Linear_Models
I've not tested/used this, but it gives a stable API.

@emdann
Copy link
Owner Author

emdann commented Oct 8, 2021

batchGLM / diffxpy from theislab

@Zethson
Copy link

Zethson commented Feb 17, 2022

Theislab dude here. Just wanted to say that we have some people working on batchGLM again and I think that it would be a good choice for you in the future.

@emdann
Copy link
Owner Author

emdann commented Feb 18, 2022

Hi @Zethson, thanks for the heads up. I actually have some bandwidth now to look into this and try a few options out.

@Zethson
Copy link

Zethson commented Feb 18, 2022

Hi @Zethson, thanks for the heads up. I actually have some bandwidth now to look into this and try a few options out.

Well, batchglm will still take a few months to be usable and well documented, but feel free to take a look nevertheless :) (development is happening on a couple of branches so don't look at master).

@picciama
Copy link

picciama commented Nov 7, 2022

Hi @Zethson, thanks for the heads up. I actually have some bandwidth now to look into this and try a few options out.

Well, batchglm will still take a few months to be usable and well documented, but feel free to take a look nevertheless :) (development is happening on a couple of branches so don't look at master).

batchglm developer here with a minor update on this for @emdann and @Zethson: The python port of edgeR using batchglm as backend is implemented for your purposes but I didn't have the time for testing / deployment yet. It's probably going to take till January until I find time for that but let me just say that for my small testing dataset it is already pretty much exactly reproducing edgeR's results.

@Zethson
Copy link

Zethson commented Nov 7, 2022

Excellent @picciama ! Thank you very much! Really think that a Python native edgeR will be super useful for the community. Just a big bonus that we can add this to Milopy.

CC @ivirshup

@Zethson
Copy link

Zethson commented Nov 7, 2022

BTW @picciama this is where the new batchGLM based implementation should then end up in -> https://github.com/theislab/pertpy/blob/development/pertpy/tools/_milopy.py#L306
(Just another if case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants