Bugfix issue7 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…makes it unlikely to collide with header attributes
Treats name attribute of parameter as alias for parameter block if differing from block name. Tested with files provided by issuer of issue emdb-empiar#7 but no explicit test added.
Treats name attribute of parameter as alias for parameter block if differing from block name. Tested with files provided by issuer of issue emdb-empiar#7 but no explicit test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok some reverts missed and name check in print not sufficient. Tests work now
I'd suggest on merge to dev and master to not rename
nametoattr_nameorblock_namebut just merge the@aliaspart inheader.py:_load_parametersand the changes to__str__methods incore.pyand other palces.Did not add new tests i guess that you have to do,
Note Hope post fixing Rebase / Merge with upstream worked without adding spurious old commits best you just take the changes from commit 9905c28. The rest is stuff you already have