Skip to content

Commit

Permalink
fix: 1.0rem safari issue
Browse files Browse the repository at this point in the history
* fix: 1.0rem safari issue

* Merge remote-tracking branch 'origin/feat/theming' into fix/units_for_safari

* test: update visual regression tests
  • Loading branch information
borisdiakur committed Nov 9, 2021
1 parent 608feac commit 3b2bbfe
Show file tree
Hide file tree
Showing 108 changed files with 270 additions and 264 deletions.
450 changes: 225 additions & 225 deletions screenshot/builds/master.json

Large diffs are not rendered by default.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.
14 changes: 9 additions & 5 deletions src/docs/components/docs-pick-theme/docs-pick-theme.css
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
background-color: var(--ld-col-rb-010);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-ocean-primary-focus);
box-shadow: inset 0 0 0 var(--ld-sp-1)
var(--ld-thm-ocean-primary-focus);
}
}
}
Expand Down Expand Up @@ -121,7 +122,8 @@
background-color: var(--ld-col-rp-010);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-bubblegum-primary-focus);
box-shadow: inset 0 0 0 var(--ld-sp-1)
var(--ld-thm-bubblegum-primary-focus);
}
}
}
Expand Down Expand Up @@ -177,7 +179,8 @@
background-color: var(--ld-col-rp-010);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-shake-primary-focus);
box-shadow: inset 0 0 0 var(--ld-sp-1)
var(--ld-thm-shake-primary-focus);
}
}
}
Expand Down Expand Up @@ -233,7 +236,8 @@
background-color: var(--ld-col-rp-010);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-solvent-primary-focus);
box-shadow: inset 0 0 0 var(--ld-sp-1)
var(--ld-thm-solvent-primary-focus);
}
}
}
Expand Down Expand Up @@ -289,7 +293,7 @@
background-color: var(--ld-col-rg-010);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-tea-primary-focus);
box-shadow: inset 0 0 0 var(--ld-sp-1) var(--ld-thm-tea-primary-focus);
}
}
}
Expand Down
19 changes: 10 additions & 9 deletions src/liquid/components/ld-checkbox/ld-checkbox.css
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@
}
~ .ld-checkbox__box {
background-color: transparent;
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-disabled-bg-col);
box-shadow: inset 0 0 0 var(--ld-sp-2)
var(--ld-checkbox-disabled-bg-col);
}

&:checked {
Expand All @@ -81,20 +82,20 @@
color: var(--ld-checkbox-col-active);
}
~ .ld-checkbox__box {
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col);
}

&:focus:focus-visible {
~ .ld-checkbox__box {
background-color: transparent;
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-focus);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-focus);
}
}
&:active,
&:active:focus-visible {
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-bg-col-active);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-active);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-active);
}
}

Expand All @@ -104,7 +105,7 @@
}
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-col);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col);
}

&:focus:focus-visible {
Expand All @@ -113,7 +114,7 @@
}
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-col-focus);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-focus);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-focus);
}
}
&:active,
Expand All @@ -123,7 +124,7 @@
}
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-col-active);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-active);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-active);
}
}
}
Expand All @@ -139,7 +140,7 @@
&:hover {
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-bg-col-hover);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-hover);
}

&:checked {
Expand All @@ -148,7 +149,7 @@
}
~ .ld-checkbox__box {
background-color: var(--ld-checkbox-col-hover);
box-shadow: inset 0 0 0 0.1rem var(--ld-checkbox-col-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-checkbox-col-hover);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

.ld-input-message__icon {
transform: translateY(0.1rem);
transform: translateY(var(--ld-sp-2));
margin-top: var(--ld-sp-2);
margin-right: var(--ld-sp-6);
flex-shrink: 0;
Expand Down
10 changes: 5 additions & 5 deletions src/liquid/components/ld-input/ld-input.css
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
border-radius: var(--ld-br-m);
display: block;
pointer-events: none;
box-shadow: inset 0 0 0 0.1rem var(--ld-input-border-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-input-border-col);
}

::slotted(*),
Expand Down Expand Up @@ -327,15 +327,15 @@
:host(:not(.ld-input--invalid):not([aria-disabled='true']):not([disabled]):hover:not(:focus-within)),
.ld-input:not(.ld-input--invalid):not([aria-disabled='true']):not([disabled]):hover:not(:focus-within) {
&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-input-border-col-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-input-border-col-hover);
}
}
}

:host(:not(.ld-input--invalid):focus-within),
.ld-input:not(.ld-input--invalid):focus-within {
&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-thm-primary);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-thm-primary);
}
}

Expand All @@ -358,7 +358,7 @@
:host(.ld-input--invalid:not([disabled]):not([aria-disabled='true'])),
.ld-input--invalid:not([disabled]):not([aria-disabled='true']) {
&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-input-text-col-invalid);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-input-text-col-invalid);
}

> input,
Expand Down Expand Up @@ -401,7 +401,7 @@
background-color: var(--ld-input-bg-col-disabled);

&::before {
box-shadow: inset 0 0 0 0.1rem var(--ld-input-border-col-disabled);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-input-border-col-disabled);
}

input,
Expand Down
20 changes: 10 additions & 10 deletions src/liquid/components/ld-radio/ld-radio.css
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
}
~ .ld-radio__box {
background-color: transparent;
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-disabled-bg-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-disabled-bg-col);
}

&:checked {
Expand All @@ -82,20 +82,20 @@
background-color: var(--ld-radio-col-active);
}
~ .ld-radio__box {
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col);
}

&:focus:focus-visible {
~ .ld-radio__box {
background-color: transparent;
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-focus);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-focus);
}
}
&:active,
&:active:focus-visible {
~ .ld-radio__box {
background-color: var(--ld-radio-bg-col-active);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-active);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-active);
}
}

Expand All @@ -105,7 +105,7 @@
}
~ .ld-radio__box {
background-color: var(--ld-radio-col);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col);
}

&:focus:focus-visible {
Expand All @@ -114,7 +114,7 @@
}
~ .ld-radio__box {
background-color: var(--ld-radio-col-focus);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-focus);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-focus);
}
}
&:active,
Expand All @@ -124,7 +124,7 @@
}
~ .ld-radio__box {
background-color: var(--ld-radio-col-active);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-active);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-active);
}
}
}
Expand All @@ -140,7 +140,7 @@
&:hover {
~ .ld-radio__box {
background-color: var(--ld-radio-bg-col-hover);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-hover);
}

&:checked {
Expand All @@ -149,7 +149,7 @@
}
~ .ld-radio__box {
background-color: var(--ld-radio-col-hover);
box-shadow: inset 0 0 0 0.1rem var(--ld-radio-col-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-radio-col-hover);
}
}
}
Expand Down Expand Up @@ -200,7 +200,7 @@
width: 100%;
height: 100%;
pointer-events: none;
box-shadow: inset 0 0 0 0.1rem var(--ld-col-rblck4);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-col-rblck4);
}

:host,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
}

&:where(:focus:focus-visible):before {
box-shadow: inset 0 0 0 0.1rem var(--ld-option-thm-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-option-thm-col);
}

&:where(:not([disabled]):not([aria-disabled='true'])) {
Expand Down
17 changes: 9 additions & 8 deletions src/liquid/components/ld-select/ld-select.css
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@
&:where(:not(.ld-select--detached):not(.ld-select--expanded)) {
:where(select),
:where(.ld-select__btn-trigger) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-col-border);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-col-border);
}
}

Expand All @@ -258,7 +258,8 @@
&:where(:not(:disabled):not([aria-disabled='true']):not(.ld-select__btn-trigger--detached):not([aria-expanded='true'])) {
@media (hover: hover) {
&:hover:not(:focus:focus-visible) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-col-border-hover);
box-shadow: inset 0 0 0 var(--ld-sp-2)
var(--ld-select-col-border-hover);
}
}
}
Expand All @@ -270,7 +271,7 @@
.ld-select--invalid .ld-select__btn-trigger--invalid {
&:where(:not(:disabled)) {
&:where(:focus:focus-visible) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-invalid-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-invalid-col);
}
}

Expand All @@ -281,7 +282,7 @@
}

&:where(:not(.ld-select__btn-trigger--ghost)) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-invalid-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-invalid-col);
}

+ .ld-icon,
Expand All @@ -292,7 +293,7 @@

@media (hover: hover) {
&:hover {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-invalid-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-invalid-col);

+ .ld-icon,
+ .ld-select__icon,
Expand Down Expand Up @@ -499,7 +500,7 @@
:where(.ld-select:not([disabled]):not([aria-disabled]):not(.ld-select--invalid)) {
.ld-select__btn-trigger {
&:where(:focus:focus-visible) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-thm-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-thm-col);
}
}

Expand Down Expand Up @@ -538,7 +539,7 @@
}
}
&:where(:focus:focus-visible) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-thm-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-thm-col);

.ld-select__icon,
+ .ld-select__icon,
Expand All @@ -562,7 +563,7 @@
:where(select:not(:disabled)),
:where(.ld-select__btn-trigger) {
&:where(:focus:focus-visible) {
box-shadow: inset 0 0 0 0.1rem var(--ld-select-thm-col);
box-shadow: inset 0 0 0 var(--ld-sp-2) var(--ld-select-thm-col);
}
}
}
Expand Down

0 comments on commit 3b2bbfe

Please sign in to comment.