fix: conditionally disconnect attribute observer

emdgroup-liquid · Dec 15, 2021 · 84259b9 · 84259b9
1 parent 793d7b5
commit 84259b9
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/src/liquid/components/ld-button/ld-button.tsx b/src/liquid/components/ld-button/ld-button.tsx
@@ -116,7 +116,7 @@ export class LdButton implements InnerFocusable, ClonesAttributes {
     this.el.removeEventListener('click', this.handleClick, {
       capture: true,
     })
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   private clickHiddenButton() {

diff --git a/src/liquid/components/ld-checkbox/ld-checkbox.tsx b/src/liquid/components/ld-checkbox/ld-checkbox.tsx
@@ -188,7 +188,7 @@ export class LdCheckbox implements InnerFocusable, ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {

diff --git a/src/liquid/components/ld-input/ld-input.tsx b/src/liquid/components/ld-input/ld-input.tsx
@@ -312,7 +312,7 @@ export class LdInput implements InnerFocusable, ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {

diff --git a/src/liquid/components/ld-label/ld-label.tsx b/src/liquid/components/ld-label/ld-label.tsx
@@ -56,7 +56,7 @@ export class LdLabel implements ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {

diff --git a/src/liquid/components/ld-radio/ld-radio.tsx b/src/liquid/components/ld-radio/ld-radio.tsx
@@ -219,7 +219,7 @@ export class LdRadio implements InnerFocusable, ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {

diff --git a/src/liquid/components/ld-toggle/ld-toggle.tsx b/src/liquid/components/ld-toggle/ld-toggle.tsx
@@ -179,7 +179,7 @@ export class LdToggle implements InnerFocusable, ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {

diff --git a/src/liquid/components/ld-typo/ld-typo.tsx b/src/liquid/components/ld-typo/ld-typo.tsx
@@ -127,7 +127,7 @@ export class LdTypo implements ClonesAttributes {
   }
 
   disconnectedCallback() {
-    this.attributesObserver.disconnect()
+    this.attributesObserver?.disconnect()
   }
 
   render() {