fix(ld-radio): remove redundant input event dispatch

emdgroup-liquid · Nov 16, 2021 · b063726 · b063726
1 parent 1e95789
commit b063726
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/src/liquid/components/ld-radio/ld-radio.tsx b/src/liquid/components/ld-radio/ld-radio.tsx
@@ -120,15 +120,14 @@ export class LdRadio implements InnerFocusable {
     }
 
     this.checked = true
-    this.el.dispatchEvent(new Event('input', { bubbles: true, composed: true }))
   }
 
   private focusAndSelect(dir: 'next' | 'prev') {
     const ldRadios = Array.from(document.querySelectorAll('ld-radio')).filter(
       (ldRadio) => ldRadio.getAttribute('name') === this.name
     )
     ldRadios.forEach((ldRadio, index) => {
-      if (ldRadio === ((this.el as unknown) as HTMLLdRadioElement)) {
+      if (ldRadio === (this.el as unknown as HTMLLdRadioElement)) {
         const targetLdRadio = ldRadios[index + (dir === 'next' ? 1 : -1)]
         if (targetLdRadio) {
           targetLdRadio.focusInner()

diff --git a/src/liquid/components/ld-radio/test/ld-radio.spec.ts b/src/liquid/components/ld-radio/test/ld-radio.spec.ts
@@ -90,20 +90,6 @@ describe('ld-radio', () => {
     expect(spyBlur).toHaveBeenCalled()
   })
 
-  it('emits input event on click', async () => {
-    const page = await newSpecPage({
-      components: [LdRadio],
-      html: `<ld-radio />`,
-    })
-    const ldRadio = page.root
-
-    const spyInput = jest.fn()
-    ldRadio.addEventListener('input', spyInput)
-    ldRadio.click()
-
-    expect(spyInput).toHaveBeenCalled()
-  })
-
   it('allows to set inner focus', async () => {
     const page = await newSpecPage({
       components: [LdRadio],