feat(ld-notice): remove bg color of error mode

emdgroup-liquid · Jan 28, 2022 · fbed5d6 · fbed5d6
1 parent b10ca2a
commit fbed5d6
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 16 deletions.
diff --git a/screenshot/builds/master.json b/screenshot/builds/master.json
@@ -6064,7 +6064,7 @@
     },
     {
       "id": "ad43b06f",
-      "image": "b728c4848c1c23bbd81f8c6190c101f3.png",
+      "image": "8b91e83528f3d3980c313baa9a0a6ad5.png",
       "userAgent": "default",
       "desc": "ld-notice css component with headline error",
       "testPath": "./src/liquid/components/ld-notice/test/ld-notice.e2e.ts",
@@ -6103,7 +6103,7 @@
     },
     {
       "id": "eba9d27f",
-      "image": "763136d88f532b45b203aaea6c0cdd76.png",
+      "image": "81d94be4776f4c6c42998787b881a53e.png",
       "userAgent": "default",
       "desc": "ld-notice css component without headline error",
       "testPath": "./src/liquid/components/ld-notice/test/ld-notice.e2e.ts",
@@ -6142,7 +6142,7 @@
     },
     {
       "id": "d21736c2",
-      "image": "b728c4848c1c23bbd81f8c6190c101f3.png",
+      "image": "8b91e83528f3d3980c313baa9a0a6ad5.png",
       "userAgent": "default",
       "desc": "ld-notice web component with headline error",
       "testPath": "./src/liquid/components/ld-notice/test/ld-notice.e2e.ts",
@@ -6181,7 +6181,7 @@
     },
     {
       "id": "449daf7a",
-      "image": "763136d88f532b45b203aaea6c0cdd76.png",
+      "image": "81d94be4776f4c6c42998787b881a53e.png",
       "userAgent": "default",
       "desc": "ld-notice web component without headline error",
       "testPath": "./src/liquid/components/ld-notice/test/ld-notice.e2e.ts",

diff --git a/screenshot/images/763136d88f532b45b203aaea6c0cdd76.png b/screenshot/images/763136d88f532b45b203aaea6c0cdd76.png
diff --git a/screenshot/images/81d94be4776f4c6c42998787b881a53e.png b/screenshot/images/81d94be4776f4c6c42998787b881a53e.png
diff --git a/screenshot/images/8b91e83528f3d3980c313baa9a0a6ad5.png b/screenshot/images/8b91e83528f3d3980c313baa9a0a6ad5.png
diff --git a/screenshot/images/b728c4848c1c23bbd81f8c6190c101f3.png b/screenshot/images/b728c4848c1c23bbd81f8c6190c101f3.png
diff --git a/src/liquid/components/ld-notice/ld-notice.css b/src/liquid/components/ld-notice/ld-notice.css
@@ -1,8 +1,8 @@
 :host,
 .ld-notice {
-  --ld-notice-error-text-col: var(--ld-thm-error);
-  --ld-notice-info-text-col: var(--ld-thm-primary);
-  --ld-notice-warning-text-col: var(--ld-thm-warning);
+  --ld-notice-error-icon-col: var(--ld-thm-error);
+  --ld-notice-info-icon-col: var(--ld-thm-primary);
+  --ld-notice-warning-icon-col: var(--ld-thm-warning);
 
   align-items: baseline;
   border-radius: var(--ld-br-l);
@@ -18,11 +18,9 @@
 
 :host(.ld-notice--error),
 .ld-notice--error {
-  background: var(--ld-thm-error-highlight);
-
   .ld-notice__icon,
   .ld-notice__headline {
-    color: var(--ld-notice-error-text-col);
+    color: var(--ld-notice-error-icon-col);
   }
 
   .ld-notice__icon {
@@ -32,12 +30,9 @@
 
 :host(.ld-notice--info),
 .ld-notice--info {
-  .ld-notice__icon {
-    color: var(--ld-notice-info-text-col);
-  }
-
+  .ld-notice__icon,
   .ld-notice__headline {
-    color: var(--ld-notice-info-text-col);
+    color: var(--ld-notice-info-icon-col);
   }
 }
 
@@ -46,8 +41,8 @@
   background: var(--ld-thm-warning-highlight);
 
   .ld-notice__icon {
-    color: var(--ld-notice-warning-text-col);
     --ld-icon-secondary-col: var(--ld-col-neutral-900);
+    color: var(--ld-notice-warning-icon-col);
   }
 
   .ld-notice__headline {