fix: add patch to fully specify resolve path in stencil output targets #502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a patch to the Stencil Vue and React output targets, resolving an issue with relatively imported modules, which need to have the .js or /index.js extension to be added to the import path in order to resolve an actual path, when working with esm in environments, where a fully specified path is the default (such as in a create react app with webpack 5, which, if not ejected and changed, has resolve.fullySpecified set to true).
Fixes #495
References:
Type of change
Is it a breaking change?
How Has This Been Tested?
In order to test this, you'll need to do the following:
fix/resolve_esm
yarn && yarn build && npm link
patch-package ;
in this line in the package.json filenpm install && npm link @emdgroup-liquid/liquid && npm start
You can test the Vue bindings as well, using the same procedure as above with the Nuxt sandbox app. However, Nuxt will not be able to resolve symlinks, so you will have to copy paste the vue dist folder into the project as a workaround.
Checklist: