Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduces default asset path to jsDelivr #527

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

toastedtoast
Copy link
Member

Description

This PR uses jsDelivr as default asset base path.
It will improve the DX when Liquid gets introduced into a project. As this is not the recommended approach for production
additional documentation will be provided.

It's marked as feature as it improves the DX but does not actually fix anything.

Docuementation will be updated with PR 506.

Type of change

Please delete options that are not relevant.

  • Feature

Is it a breaking change?

  • Yes
  • No

How Has This Been Tested?

Please describe the tests that you've added and run to verify your changes.
Provide instructions, so we can reproduce.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • New and existing tests pass locally with my changes

@vercel
Copy link

vercel bot commented Feb 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
liquid ✅ Ready (Inspect) Visit Preview Feb 21, 2023 at 10:32AM (UTC)

@borisdiakur borisdiakur merged commit 140b298 into main Feb 21, 2023
@borisdiakur borisdiakur deleted the feat/default-asset-path branch February 21, 2023 12:55
@github-actions
Copy link

🎉 This PR is included in version 4.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants