Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add register_hooks utility #247

Closed
wants to merge 23 commits into from
Closed

Add register_hooks utility #247

wants to merge 23 commits into from

Commits on Jun 16, 2024

  1. Add register_hook

    @RimRihana @AdrianSosic
    RimRihana authored and AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0322e97 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md

    @RimRihana @AdrianSosic
    RimRihana authored and AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    97a2729 View commit details
    Browse the repository at this point in the history

  3. Add basic callable example

    @RimRihana @AdrianSosic
    RimRihana authored and AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    633aa66 View commit details
    Browse the repository at this point in the history

  4. Add register_hook tests

    @RimRihana @AdrianSosic
    RimRihana authored and AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8e48e21 View commit details
    Browse the repository at this point in the history

  5. Fix wording

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    eed3062 View commit details
    Browse the repository at this point in the history

  6. Redesign example

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    94cc563 View commit details
    Browse the repository at this point in the history

  7. Drop unnecessary tests

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    f38ea3d View commit details
    Browse the repository at this point in the history

  8. Refactor names in test

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    2284d45 View commit details
    Browse the repository at this point in the history

  9. Add failing test case: missing parameters

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8944aab View commit details
    Browse the repository at this point in the history

  10. Add check for same number of parameters

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    183073d View commit details
    Browse the repository at this point in the history

  11. Reveal failing test case: different names not annotated

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    38de69a View commit details
    Browse the repository at this point in the history

  12. Fix validation logic

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    d39978b View commit details
    Browse the repository at this point in the history

  13. Extend registration logic 

    * Differentiate between pre- and post-hooks
* Allow multiple hooks per hook category
    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    748ad58 View commit details
    Browse the repository at this point in the history

  14. Add timer hook

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3af714d View commit details
    Browse the repository at this point in the history

  15. Rephrase example header

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    48e6ab4 View commit details
    Browse the repository at this point in the history

  16. Rename example file

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0cfaf4b View commit details
    Browse the repository at this point in the history

  17. Update docstring of register_hooks

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    10ffec6 View commit details
    Browse the repository at this point in the history

  18. Drop searchspace annotations

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    0d4b791 View commit details
    Browse the repository at this point in the history

  19. Refactor argument matching logic 

    * The hook signature may now expose a subset of the target parameters
* Defaults from the target are automatically reused
    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    67efa44 View commit details
    Browse the repository at this point in the history

  20. Add missing blank line 

    Required for proper rendering
    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8a771f8 View commit details
    Browse the repository at this point in the history

  21. Monkeypatch instance method instead of class function

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    83b0906 View commit details
    Browse the repository at this point in the history

  22. Explain difference between object instances

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3d1b68c View commit details
    Browse the repository at this point in the history

  23. Allow arbitrary hook annotations for unannotated target parameters

    @AdrianSosic
    AdrianSosic committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    e24b49b View commit details
    Browse the repository at this point in the history