Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Now v2 support #89

Merged
merged 3 commits into from
Oct 27, 2019
Merged

Add Now v2 support #89

merged 3 commits into from
Oct 27, 2019

Conversation

emedvedev
Copy link
Owner

@emedvedev emedvedev commented Oct 27, 2019

Fixes #73.

It almost works, but hilariously enough, my Now deployment got stuck and now I can't deploy anything else from my account.

@XhmikosR if you want, you can try deploying this branch with now . I'm not sure static routing works though, need to do some more debugging once the Zeit folks get my account working again. :)

@vercel
Copy link

vercel bot commented Oct 27, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@XhmikosR
Copy link
Collaborator

XhmikosR commented Oct 27, 2019 via email

@emedvedev
Copy link
Owner Author

Demo link updated, branch protection enabled. :)

I think the easiest way to deploy the latest npm version would be to just roll it out locally, since that version doesn't work with Now anymore. I've tried fiddling with it, but no luck; locally everything works though.

@XhmikosR
Copy link
Collaborator

Shouldn't https://slackin-extended.now.sh/iframe work too?

@XhmikosR
Copy link
Collaborator

XhmikosR commented Oct 28, 2019

@emedvedev you could just cherry pick your Now fixes patches in a branch and temporarily deploy that maybe? It should work in theory

@emedvedev
Copy link
Owner Author

@XhmikosR that's what I've tried, but it didn't work, because Now requires some of the changes to the old build process and package.json to be cherry-picked, too. Tried to do that as well, but gave up after a while. :)

@XhmikosR
Copy link
Collaborator

Ah, well, I guess we'll live without a comparison. :/

Would be nice to have some numbers because I believe there will be a huge improvement between 1.1.11 and the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Now v2 support
2 participants