-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Now v2 support #89
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). |
Can you deploy the latest npm published version somewhere temporarily, for
one two days, so that I can run some tests?
Also, can you update the demo link in readme?
BTW if you enable branch protection for master, there's an option to keep
branches up to date which will have a button you can press. Alternatively
we can add an action.
…On Sun, Oct 27, 2019, 23:08 Ed Medvedev ***@***.***> wrote:
Merged #89 <#89> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#89?email_source=notifications&email_token=AACVLNLYPSR6PFB7NA3RAE3QQXYL7A5CNFSM4JFSTVU2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUO5ERLQ#event-2746894510>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACVLNLFVMN6U26LWMHD3CTQQXYL7ANCNFSM4JFSTVUQ>
.
|
Demo link updated, branch protection enabled. :) I think the easiest way to deploy the latest npm version would be to just roll it out locally, since that version doesn't work with Now anymore. I've tried fiddling with it, but no luck; locally everything works though. |
Shouldn't |
@emedvedev you could just cherry pick your Now fixes patches in a branch and temporarily deploy that maybe? It should work in theory |
@XhmikosR that's what I've tried, but it didn't work, because Now requires some of the changes to the old build process and package.json to be cherry-picked, too. Tried to do that as well, but gave up after a while. :) |
Ah, well, I guess we'll live without a comparison. :/ Would be nice to have some numbers because I believe there will be a huge improvement between 1.1.11 and the next version. |
Fixes #73.
It almost works, but hilariously enough, my Now deployment got stuck and now I can't deploy anything else from my account.
@XhmikosR if you want, you can try deploying this branch with
now .
I'm not sure static routing works though, need to do some more debugging once the Zeit folks get my account working again. :)