[pinpoint-apm#2815] add hasText()

emeroad · Aug 7, 2017 · 6d7af76 · 6d7af76
1 parent 494c626
commit 6d7af76
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/commons/src/main/java/com/navercorp/pinpoint/common/util/StringUtils.java b/commons/src/main/java/com/navercorp/pinpoint/common/util/StringUtils.java
@@ -44,6 +44,20 @@ public static boolean hasLength(final String string) {
         return string != null && string.length() > 0;
     }
 
+    public static boolean hasText(String string) {
+        if (isEmpty(string)) {
+            return false;
+        }
+
+        final int length = string.length();
+        for (int i = 0; i < length; i++) {
+            if (!Character.isWhitespace(string.charAt(i))) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     public static <T> int getLength(final String string) {
         return getLength(string, 0);
     }

diff --git a/commons/src/test/java/com/navercorp/pinpoint/common/util/StringUtilsTest.java b/commons/src/test/java/com/navercorp/pinpoint/common/util/StringUtilsTest.java
@@ -172,6 +172,14 @@ public void testTokenizeToStringList_compatibility() throws Exception {
 
     }
 
+    @Test
+    public void testTokenizeToStringList_nullValue() throws Exception {
+
+        List<String> tokenList = StringUtils.tokenizeToStringList(null, ",");
+        Assert.assertEquals(tokenList.size(), 0);
+
+    }
+
 
     private static List<String> backup_splitAndTrim(String value, String separator) {
         if (StringUtils.isEmpty(value)) {
@@ -211,4 +219,28 @@ public void testGetLength_defaultNull() {
         Assert.assertEquals(StringUtils.getLength("abc"), 3);
     }
 
+
+    @Test
+    public void testHasLength() {
+
+        Assert.assertTrue(StringUtils.hasLength("1"));
+        Assert.assertTrue(StringUtils.hasLength(" "));
+
+
+        Assert.assertFalse(StringUtils.hasLength(null));
+        Assert.assertFalse(StringUtils.hasLength(""));
+    }
+
+    @Test
+    public void testHasText() {
+
+        Assert.assertTrue(StringUtils.hasText("1"));
+        Assert.assertTrue(StringUtils.hasText("  1"));
+
+        Assert.assertFalse(StringUtils.hasText(null));
+        Assert.assertFalse(StringUtils.hasText(""));
+        Assert.assertFalse(StringUtils.hasText("  "));
+
+    }
+
 }