This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
freebsd: Do not use cr_pid from LOCAL_PEERCRED #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOCAL_PEERCRED is used as substitute for SO_PEERCRED on FreeBSD. One of the fields needed from there is the PID of the peer process. However, while SO_PEERCRED returns the PID at the time of connect(2), LOCAL_PEERCRED returns the PID at the time of listen(2). If the dbus daemon fork(2)'d after listen(2) to daemonize, then the PID returned will no longer exist, which breaks basu. Remove the use of cr_pid for now, as it cannot be used.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOCAL_PEERCRED is used as substitute for SO_PEERCRED on FreeBSD. One of
the fields needed from there is the PID of the peer process. However,
while SO_PEERCRED returns the PID at the time of connect(2),
LOCAL_PEERCRED returns the PID at the time of listen(2). If the dbus
daemon fork(2)'d after listen(2) to daemonize, then the PID returned
will no longer exist, which breaks basu.
Remove the use of cr_pid for now, as it cannot be used.
/cc @jbeich