Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DKIM t=s key flag not supported #44

Open
AGWA opened this issue Mar 15, 2021 · 2 comments
Open

DKIM t=s key flag not supported #44

AGWA opened this issue Mar 15, 2021 · 2 comments

Comments

@AGWA
Copy link
Contributor

AGWA commented Mar 15, 2021

When s is in a key's flags list, then:

Any DKIM-Signature header fields using the "i=" tag MUST have the same domain value on the right-hand side of the "@" in the "i=" tag and the value of the "d=" tag. That is, the "i=" domain MUST NOT be a subdomain of "d=". Use of this flag is RECOMMENDED unless subdomaining is required.

(RFC 6376 Section 3.6.1)

Currently, go-msgauth's DKIM verifier unconditionally allows the i= domain to be a subdomain of d=.
@emersion
Copy link
Owner

Good catch. Patches welcome!

gowthamgts added a commit to gowthamgts/go-msgauth that referenced this issue Jul 31, 2021
@gowthamgts
adds support for DKIM flags. fixes emersion#44
5294351
@gowthamgts
Copy link

issued a PR for this: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AGWA @emersion @gowthamgts