Skip to content
This repository has been archived by the owner on Dec 6, 2020. It is now read-only.

Ensure Mastodon compatibility #10

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Luzifer
Copy link
Contributor

@Luzifer Luzifer commented Nov 19, 2018

These changes ensure a Mastodon instance is capable of sending /salmon requests to an application driven by this library.

  • Fixes the retrieval of application/xrd+xml; charset=utf-8 content-types
  • Fixes the signature hash calculation by using URLEncoding instead of RawURLEncoding

This change is integration-tested for retrieving salmon information from a Mastodon 2.6.1 instance. It should be tested for sending those information and for compatibility to other oStatus instances.

Signed-off-by: Knut Ahlers <knut@ahlers.me>
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@codecov-io
Copy link

Codecov Report

Merging #10 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   42.96%   43.18%   +0.21%     
==========================================
  Files           7        7              
  Lines         519      521       +2     
==========================================
+ Hits          223      225       +2     
  Misses        246      246              
  Partials       50       50
Impacted Files Coverage Δ
salmon/magic.go 65.65% <100%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c122f2...b5db875. Read the comment docs.

Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@emersion emersion merged commit ef3785e into emersion:master Nov 20, 2018
@emersion
Copy link
Owner

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants