Enable LMTP over TCP #123
Enable LMTP over TCP #123
Conversation
remove check that forbids LMTP over TCP introduce Network config option, to choose between TCP and unix sockets add a warning to the documentation that LMTP should not be used for WAN communication
test default Network config behavior test error for empty lmtp address test lmtp listening on tcp port
lmtp_server_test.go
Outdated
| s.Domain = "localhost" | ||
| s.AllowInsecureAuth = true | ||
|
|
||
| testPort := rand.Int31n(65535-1024) + 1024 |
There was a problem hiding this comment.
This is fragile because the port could be in use. Use port zero instead.
There was a problem hiding this comment.
Totally agree, do you know a way to get the actually used port then? The other test code uses Serve with a custom listener, this here tests logic in ListenAndServe and can't use that
There was a problem hiding this comment.
Actual listening port should be available via net.Listener.Addr().
| // Listen configures a listener according to the server configuration, without TLS | ||
| // This listener can then be passed to Serve. If access to the listener is not needed, then the | ||
| // combined function ListenAndServe can be used | ||
| func (s *Server) Listen() (net.Listener, error) { |
There was a problem hiding this comment.
The other option would be to put the tests that test the listener setup inside the smtp package. Would that be okay?
| // ListenTLS configures a listener according to the server configuration, with TLS | ||
| // This listener can then be passed to Serve. If access to the listener is not needed, then the | ||
| // combined function ListenAndServe can be used | ||
| func (s *Server) ListenTLS() (net.Listener, error) { |
|
|
||
| s.Network = "" | ||
| s.LMTP = true | ||
| s.Addr = "./testsocket" |
There was a problem hiding this comment.
We can't do that, this will clutter the current working directory.
There was a problem hiding this comment.
We could put it in os.TempDir()
|
Superseded by #212 |
Changes: