Make sure to handle a PROPFIND to /
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the Reminders app in `iOS`/`macOS` does this request as the first thing when setting up an account, so it seems reasonable to handle it for us. This just returns the most basic current-user-principal now, but that should hopefully be enough to continue the process.
|
It sounds reasonable to serve a default user principal when the library user doesn't handle that case.
|
|
Hm, actually, no, this is the root, not the user principal… Nevermind about using |
|
Yeah, I'm not competent enough in I just assume that it's proper to respond to the |
|
Okay. Can we copy-paste Also I think the |
|
@emersion Done! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the Reminders app in
iOS/macOSdoes this request as the first thing when setting up an account, so it seems reasonable to handle it for us.This just returns the most basic current-user-principal now, but that should hopefully be enough to continue the process.