sync-collection for client #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Apr 2, 2020
emersion
reviewed
Apr 2, 2020
emersion
reviewed
Apr 2, 2020
|
done @emersion :D |
|
ouch, for some reason the PR got mixed up with #36 which you already merged.... just ignore that |
emersion
reviewed
Apr 3, 2020
emersion
reviewed
Apr 3, 2020
emersion
reviewed
Apr 3, 2020
emersion
reviewed
Apr 3, 2020
emersion
reviewed
Apr 3, 2020
emersion
requested changes
Apr 3, 2020
There was a problem hiding this comment.
Thanks for the update, this version looks much better. I left a few more comments.
Can you rebase against the latest commit from master and squash all commits into a single one? See https://git-rebase.io/
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
2 times, most recently
from
1b6a9fe
to
6686a53
Compare
|
done. |
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
2 times, most recently
from
d594034
to
7af66c2
Compare
emersion
reviewed
Apr 4, 2020
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
3 times, most recently
from
bc51215
to
8710713
Compare
|
fixed |
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
6 times, most recently
from
267bad1
to
f5c8b6a
Compare
|
@emersion I've implemented all of your comments... can you please re-review it? |
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
from
f5c8b6a
to
7da1bd6
Compare
emersion
reviewed
Apr 14, 2020
emersion
reviewed
Apr 14, 2020
emersion
reviewed
Apr 14, 2020
emersion
requested changes
Apr 14, 2020
|
@emersion any comment? |
AlmogBaku
force-pushed
the
rfc6578-collection-sync
branch
from
7da1bd6
to
e57f9a4
Compare
|
done. @emersion Let's merge 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic sync-collection operation for client
partial implementation of #35