Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: use http.TimeFormat to marshal Time values #48

Merged
merged 2 commits into from
Mar 16, 2021
Merged

internal: use http.TimeFormat to marshal Time values #48

merged 2 commits into from
Mar 16, 2021

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Mar 16, 2021

Fixes #47.

Signed-off-by: Sebastien Binet binet@cern.ch

@sbinet
internal: use http.TimeFormat to marshal Time values
8cc2d61 
Fixes emersion#47.

Signed-off-by: Sebastien Binet <binet@cern.ch>
emersion
emersion approved these changes Mar 16, 2021
View reviewed changes
Copy link
Owner

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@emersion
Copy link
Owner

Ah, CI is unhappy:

internal/elements_test.go:53:32: got.Equal undefined (type Time has no field or method Equal)

Probably need to do the conversion to time.Time.

@sbinet
PS2
d6ce9af 
Signed-off-by: Sebastien Binet <binet@cern.ch>
@emersion emersion merged commit 8efde26 into emersion:master Mar 16, 2021
@sbinet sbinet deleted the issue-47 branch March 16, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal: r/w roundtrip of Time broken
2 participants
@sbinet @emersion