carddav: add filtering and matching helper functions #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Mar 1, 2022
| if field == nil { | ||
| return prop.IsNotDefined, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
At this point field != nil so we maybe need to return false in case prop.IsNotDefined is set?
There was a problem hiding this comment.
Good catch, thanks! Fixed.
|
Apart from this comment, looks pretty good to me! |
Updates emersion/hydroxide#159. Signed-off-by: Sebastien Binet <binet@cern.ch> Co-authored-by: Conrad Hoffmann <ch@bitfehler.net>
bitfehler
force-pushed
the
bitfehler/carddav-filter
branch
from
5a3bf69
to
fa1cce5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #49
I addressed all your comments and removed two test cases that I think were a misunderstanding about the semantics of
DataRequest.AllProp.I did add handling of
carddav.PropFilter.IsNotDefinedbecause it seemed simple, let me know if I got that wrong there.About the collation handling, I added the TODO, but it seems this needs support in the
TextMatchtype first, correct?