caldav: add support for getcontentlength property #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfehler
force-pushed
the
bitfehler/caldav-content-length
branch
from
eadeefa
to
3319296
Compare
|
Can we also set the |
|
Hm, interesting. I didn't do that because in my tests it was always already there. But I just read the docs for ResponseWriter, and they say
So I assume that is not to be relied upon and we should do it explicitly? |
|
Hm, that's interesting indeed. Yeah, the body could contain a lot of data with embedded resources (contact pictures, etc), so it's better to set it manually if the backend supplies it. |
emersion
force-pushed
the
bitfehler/caldav-content-length
branch
from
5eedbfd
to
cd07ac5
Compare
Allow the backend to provide a value for the `getcontentlength` property as described in [RFC 2518 section 13.4][1]. The implementation treats is as optional, allthough it is a required property per RFC. Most clients do perfectly fine without it, though. Properly setting this in the backend makes the CalDAV collection listable with clients that do require it, e.g. cadaver. [1]: https://datatracker.ietf.org/doc/html/rfc2518#section-13.4
Now that the backend can supply this value, use it for explicitly setting the header in GET/HEAD responses if available.
emersion
force-pushed
the
bitfehler/caldav-content-length
branch
from
cd07ac5
to
e69ac47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the backend to provide a value for the
getcontentlengthpropertyas described in RFC 2518 section 13.4.
The implementation treats is as optional, allthough it is a required
property per RFC. Most clients do perfectly fine without it, though.
Properly setting this in the backend makes the CalDAV collection
listable with clients that do require it, e.g. cadaver.