carddav: fix PROPFIND for all path layouts #99
Conversation
Refactor the PROPFIND handling to properly support all possible path layouts (from "everything at /" to "everything at different path"). This includes adding a new method the Backend interface, as it is the authority that determines the path layout. This fixes the recent regression of the broken "everything at /" layout. It also already provides the needed bits and pieces to support multiple address books.
|
So, this is sort of v2 of #87, but completely different. First of all, it fixes the regression I introduced (and un-comments the respective test case). I successfully tested the "all at /" case with both cadaver and TB/CardBook. The depth handling is a bit confusing, but I think bearable. It won't be simple if we want to support these different layouts. The good news is that all this should already (mostly) work with multiple address books, should we ever get there 😉 I've stared at this for a too long now, and I figured your fresh eyes would surely have some valuable input, so here we go 🙂 |
| // Backend is a CardDAV server backend. | ||
| type Backend interface { | ||
| CardDAVResourceType(ctx context.Context, path string) (ResourceType, error) |
There was a problem hiding this comment.
One thing I was unsure about: I would have just named this ResourceType(), but we'd need the same thing for CalDAV eventually, and it's better to allow one type to implement both interfaces (i.e. keep the interfaces conflict-free).
One option might be to make this generic enough, e.g.: user principal, home set, collection, object - and then use that for both? Not sure, let me know if you have ideas...
See emersion#100 for details. Obsoletes emersion#99.
See emersion#100 for details. Obsoletes emersion#99.
See emersion#100 for details. Obsoletes emersion#99.
|
Made obsolete by #101 |
Refactor the PROPFIND handling to properly support all possible path
layouts (from "everything at /" to "everything at different path"). This
includes adding a new method the Backend interface, as it is the
authority that determines the path layout.
This fixes the recent regression of the broken "everything at /" layout.
It also already provides the needed bits and pieces to support multiple
address books.