Remove deprecated IMAP extension dependencies #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, great, the build failed. I must have made a mistake when building locally; sorry about that. |
|
What a mess. I was having trouble with the Guix build system; it kept falling back to a different commit making me assume the package built. I finally figured out each reference to |
|
Yup, looks good! Please squash and I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I'm packaging Hydroxide for Guix, and I noticed that
go-imap-moveandgo-imap-specialusehave both been merged intogo-imap. In order to avoid packaging the outdated extensions as dependencies, I've attempted to remove them. I'm not a Go developer, so I'm wary that what I intend might not be as simple as what I'm submitting, but it builds and runs (so far) without issue.If anyone would like to correct my ignorance, that'd be great. Otherwise, I hope this PR can be merged soon. 🤞