Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style differently urgent/low priority notifications #3

Closed
emersion opened this issue May 6, 2018 · 2 comments · Fixed by #43
Closed

Style differently urgent/low priority notifications #3

emersion opened this issue May 6, 2018 · 2 comments · Fixed by #43
Labels
enhancement New feature or request

Comments

@emersion
Copy link
Owner

emersion commented May 6, 2018 •
edited
Loading

Maybe implement some sort of filtering system, e..g to be able to style differently notifications coming from a specific app?

Depends on #7, I don't want to add CLI flags for this.
@emersion emersion added the enhancement New feature or request label May 6, 2018
@vilhalmer
Copy link
Collaborator

I would propose implementing this as a combination of mpv's concept of profiles and sway's criteria syntax. So, for example, in this configuration Firefox notifications inherit the global margin and padding, but are orange. Anything with high urgency that also has at least one action defined has red text:

margin=30
padding=10
background-color=#eeeeee

[app-name="Firefox"]
background-color=#dd9b59

[urgency=high actionable]
text-color=#ff00000

This will require pcre support if we want to have matching on the summary and body, but that could wait until a future PR.

@emersion
Copy link
Owner Author

+1 to this design, looks great

@emersion emersion mentioned this issue May 17, 2018
Merged
@vilhalmer vilhalmer mentioned this issue May 20, 2018
Closed
22 tasks
@emersion emersion mentioned this issue May 21, 2018
Merged
This was referenced May 22, 2018
Closed
Closed
@vilhalmer vilhalmer mentioned this issue Jun 3, 2018
Merged
@vilhalmer vilhalmer mentioned this issue Jun 11, 2018
Merged
bobsaintcool added a commit to bobsaintcool/mako that referenced this issue Apr 7, 2019
@bobsaintcool
# This is a combination of 7 commits.
0573e21 
# This is the 1st commit message:

Add a basic makoctl completion function for ZSH

# This is the commit message emersion#2:

Add zsh completion support into meson

Provide a way for maintainer/build system to automatically install zsh
completion files.

# This is the commit message emersion#3:

Add zsh completion for mako

# This is the commit message emersion#4:

Include zsh completation system for mako into meson

# This is the commit message emersion#5:

Revert "Include zsh completation system for mako into meson"

This reverts commit 3bdd8a8.

To fix meson syntax typo.

# This is the commit message emersion#6:

Add mako to meson build

# This is the commit message emersion#7:

Fix indent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Criteria vilhalmer/mako
2 participants
@vilhalmer @emersion