Unbreak build on FreeBSD #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
event-loop.c:58:24: error: use of undeclared identifier 'CLOCK_MONOTONIC'
.fd = timerfd_create(CLOCK_MONOTONIC, TFD_CLOEXEC),
^
event-loop.c:58:41: error: use of undeclared identifier 'O_CLOEXEC'
.fd = timerfd_create(CLOCK_MONOTONIC, TFD_CLOEXEC),
^
/usr/local/include/libepoll-shim/sys/timerfd.h:12:21: note: expanded from macro 'TFD_CLOEXEC'
#define TFD_CLOEXEC O_CLOEXEC
^
event-loop.c:140:16: error: use of undeclared identifier 'CLOCK_MONOTONIC'
clock_gettime(CLOCK_MONOTONIC, &timer->at);
^
emersion
reviewed
Dec 21, 2020
emersion
reviewed
Dec 21, 2020
event-loop uses timerfd/signalfd which are Linux-only but BSDs have a shim via kqueue. On FreeBSD libwayland uses epoll-shim by default, so the build fails at linking instead of compilation stage. ld: error: undefined symbol: timerfd_create >>> referenced by event-loop.c:58 (../event-loop.c:58) >>> mako.p/event-loop.c.o:(init_event_loop) ld: error: undefined symbol: epoll_shim_close >>> referenced by event-loop.c:70 (../event-loop.c:70) >>> mako.p/event-loop.c.o:(finish_event_loop) ld: error: undefined symbol: timerfd_settime >>> referenced by event-loop.c:120 (../event-loop.c:120) >>> mako.p/event-loop.c.o:(update_event_loop_timer) ld: error: undefined symbol: epoll_shim_read >>> referenced by event-loop.c:166 (../event-loop.c:166) >>> mako.p/event-loop.c.o:(handle_event_loop_timer) ld: error: undefined symbol: signalfd >>> referenced by event-loop.c:28 (../event-loop.c:28) >>> mako.p/event-loop.c.o:(init_signalfd)
Unlike Alpine it tests system basu package.
|
Now that basu is tested on FreeBSD would it make sense to switch Alpine to |
|
Indeed, would be better to get full coverage for all providers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on emersion/basu#32
Runtime seems to work fine but I haven't tested much: