This repository has been archived by the owner on Feb 13, 2022. It is now read-only.
Fix imap #50
Merged
Fix imap #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Jan 7, 2018
backend/imap/attachments.go
Outdated
| @@ -53,7 +53,12 @@ func (b *Messages) ReadAttachment(user, id string) (att *backend.Attachment, out | |||
| return | |||
| } | |||
|
|
|||
| att, r := parseAttachment(data.GetBody("BODY["+partId+"]")) | |||
| var bodySectionName *imap.BodySectionName | |||
There was a problem hiding this comment.
Please use tabs for indentation! (you can go fmt your source code to fix it btw)
emersion
reviewed
Jan 7, 2018
backend/imap/attachments.go
Outdated
| @@ -53,7 +53,12 @@ func (b *Messages) ReadAttachment(user, id string) (att *backend.Attachment, out | |||
| return | |||
| } | |||
|
|
|||
| att, r := parseAttachment(data.GetBody("BODY["+partId+"]")) | |||
| var bodySectionName *imap.BodySectionName | |||
| bodySectionName, err = imap.ParseBodySectionName(imap.FetchItem("BODY"+partId+"]")) | |||
emersion
reviewed
Jan 7, 2018
backend/imap/conn.go
Outdated
| @@ -151,7 +151,7 @@ func (b *conns) idle(clt *client) error { | |||
| c := clt.conn | |||
|
|
|||
| mailbox := "INBOX" | |||
| if c.Mailbox != nil && c.Mailbox.Name != mailbox { | |||
| if c.Mailbox != nil && c.Mailbox().Name != mailbox { | |||
There was a problem hiding this comment.
c.Mailbox is never nil because it's a function. You want to check if c.Mailbox() is nil instead.
emersion
reviewed
Jan 7, 2018
backend/imap/conn.go
Outdated
| @@ -283,7 +291,7 @@ func (b *conns) selectMailbox(user, mailbox string) (err error) { | |||
| } | |||
| defer unlock() | |||
|
|
|||
| if c.Mailbox == nil || c.Mailbox.Name != mailbox { | |||
| if c.Mailbox == nil || c.Mailbox().Name != mailbox { | |||
emersion
reviewed
Jan 7, 2018
|
Okay, I added some commits to address these issues and pushed them up. Do I need to do anything on github, like make a new pull request, or move some sort of pointer on this PR? Or does the pull request track the branch and I'm all set? |
|
Thanks! |
This was referenced Jan 7, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it so that neutron compiles, at least, fixing #49
I'm not entirely sure I dealt with MailboxUpdate correctly, though. I haven't been able to test yet, due to possibly-unrelated reasons. But I wanted to make these changes at least available to review while I fixed my other problems.