Makefile clobbers config #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know what I messed up that it looks like this PR has 7 commits included, but feel free to close it and directly make the change yourself, if you think it's worth fixing. |
It should be fixed by |
|
I'm not sure how other software handles this situation, it doesn't seem like Meson is doing anything special. |
jaknel
force-pushed
the
makefile-clobbers-config
branch
2 times, most recently
from
1921c33
to
18d6fa0
Compare
jaknel
force-pushed
the
makefile-clobbers-config
branch
from
18d6fa0
to
d555994
Compare
hhirtz
reviewed
Oct 5, 2021
emersion
added a commit
that referenced
this pull request
Oct 8, 2021
Use `test -f` instead of `cp -n`, because the former is POSIX. References: #32
|
Fixed in 81782fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing Makefile
make installbehavior is not expected./etc/soju/configwill be overwritten with config.in every time# make installruns.I changed
cp -ftocp -nwhich will avoid clobbering the existing file.Another option is for
make installto copy config.in to something like/etc/soju/config.sample