Upgrade to latest Rails 4 release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix load action_controller/responder, test multiple rails versions
Add config.to_spreadsheet.renderer option. Fixes glebm#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: https://emexpower.leankit.com/Boards/View/43641214/295021877
Related PR: https://github.com/emex/emex/pull/2690
Note: Please base this off of the Partners work, if that's not merged in already.
This card covers moving the EMEX app to the latest Rails 4 release (not Rails 5, if it's released by now.)
I recommend working through the minor releases in steps:
http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-0-to-rails-4-1
http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-1-to-rails-4-2
While does this work, if you see large changes that need to be made as part of fixing a deprecation warning, feel free to spin those off into separate cards.
We will need a major QA effort before releasing this.