Reload the LED pattern generator on setting change #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this it requires a reboop of the badge in order for the led pattern to actually change.
The old code set fps to 0, meaning the pattern is never checked again. Changing this to 1 means the background task won't actually exit when set to the off pattern, which allows changing the pattern without a reboot
|
Fixed issue when transitioning over the 'off' pattern, and LED display in simulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this it requires a reboop of the badge in order for the led pattern to actually change.
I have not tested this on an actual badge, only in the simulator - which doesn't have LED's!
This could be a lot more elegant if we allow apps to subscribe for callbacks when a specific settings key is updated.