Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venue allocations for attendee content get re-venued #1556

Closed
SamLR opened this issue May 17, 2024 · 5 comments · Fixed by #1571
Closed

Venue allocations for attendee content get re-venued #1556

SamLR opened this issue May 17, 2024 · 5 comments · Fixed by #1571

Comments

@SamLR
Copy link
Member

SamLR commented May 17, 2024

content that has been converted to attendee content (e.g. Karaoke) can't be set correctly to e.g. workshops

@mscroggs
Copy link
Contributor

For example: https://www.emfcamp.org/cfp-review/proposals/542?show_user_scheduled=True should be in FieldFX

@marksteward
Copy link
Member

To be clear, if you try changing the allowed venues, it creates a transaction but with no changes.

@marksteward
Copy link
Member

marksteward commented May 17, 2024

Caused by https://github.com/emfcamp/Website/blob/main/models/cfp.py#L648-L650 (942847a).

I'm guessing all the workshop venues should be set to allow user content, and this logic should be changed to just remove scheduled_content_only venues.

In general, this sort of logic belongs in the form or view, not the model. It's too obscure there.

@marksteward
Copy link
Member

Hmm, this shouldn't actually matter, because the scheduler currently ignores user-scheduled content. So you can just ignore the list of allowed_venues and set the potential/scheduled venue by hand.

@marksteward marksteward closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
@Jonty Jonty reopened this May 19, 2024
@Jonty
Copy link
Member

Jonty commented May 19, 2024

This is still actually an issue according to Katie, will try and look at it today.

SamLR added a commit that referenced this issue May 19, 2024
Sometimes it's not really attendee content (e.g. karaoke)

Closes #1556
SamLR added a commit that referenced this issue May 19, 2024
Sometimes it's not really attendee content (e.g. karaoke)

Closes #1556
SamLR added a commit that referenced this issue May 19, 2024
Sometimes it's not really attendee content (e.g. karaoke)

Closes #1556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants