Replace Microsoft.Azure.Storage.Blob with Azure.Storage.Blobs package

[inthemedium]

Replace Microsoft.Azure.Storage.Blob with Azure.Storage.Blobs package.

Upgrading is a good idea because

1. Microsoft.Azure.Storage.Blob is no longer supported
2. Azure.Storage.Blobs will get bug fixes/new features
3. Azure.Storage.Blobs supports modern auth (service principals, managed identities)

[emgarten]

I'll update the github actions so we can run the full functional tests against this branch. The functional tests will run against a real storage account and verify things are working.

[inthemedium]

There isn't an 1:1 equivalent of this enum in the new API, so I kept the default values which looks like this:

        /// <summary>
        /// The <see cref="GetBlobsAsync"/> operation returns an async
        /// sequence of blobs in this container.  Enumerating the blobs may
        /// make multiple requests to the service while fetching all the
        /// values.  Blobs are ordered lexicographically by name.
        ///
        /// For more information, see
        /// <see href="https://docs.microsoft.com/rest/api/storageservices/list-blobs">
        /// List Blobs</see>.
        /// </summary>
        /// <param name="traits">
        /// Specifies trait options for shaping the blobs.
        /// </param>
        /// <param name="states">
        /// Specifies state options for filtering the blobs.
        /// </param>
        /// <param name="prefix">
        /// Specifies a string that filters the results to return only blobs
        /// whose name begins with the specified <paramref name="prefix"/>.
        /// </param>
        /// <param name="cancellationToken">
        /// Optional <see cref="CancellationToken"/> to propagate
        /// notifications that the operation should be cancelled.
        /// </param>
        /// <returns>
        /// An <see cref="AsyncPageable{T}"/> describing the
        /// blobs in the container.
        /// </returns>
        /// <remarks>
        /// A <see cref="RequestFailedException"/> will be thrown if
        /// a failure occurs.
        /// </remarks>
        public virtual AsyncPageable<BlobItem> GetBlobsAsync(
            BlobTraits traits = BlobTraits.None,
            BlobStates states = BlobStates.None,
            string prefix = default,
            CancellationToken cancellationToken = default)

[inthemedium]

docs for states and traits:
https://learn.microsoft.com/en-us/dotnet/api/azure.storage.blobs.models.blobstates?view=azure-dotnet
https://learn.microsoft.com/en-us/dotnet/api/azure.storage.blobs.models.blobtraits?view=azure-dotnet

[emgarten]

For states the default looks correct.
Possibly the metadata trait is needed to get the properties such as the content type and content encoding, I can't tell from the docs if those come down by default.

[inthemedium]

I'll update the github actions so we can run the full functional tests against this branch. The functional tests will run against a real storage account and verify things are working.

Additionally, I ran the tests against a real account and ran every command against a real account with the debugger attached.

[emgarten]

For some reason the linux builds are unhappy

Error: /home/runner/work/Sleet/Sleet/src/SleetLib/FileSystem/AzureFile.cs(66,33): error CS0111: Type 'AzureFile' already defines a member called 'CopyFromSource' with the same parameter types [/home/runner/work/Sleet/Sleet/src/SleetLib/SleetLib.csproj::TargetFramework=netstandard2.0]

[emgarten]

Functional tests are passing, things look good except for that AzureFile error on linux which I don't see how that would happen.

[emgarten]

I can see now, dotnet format is having a lot of trouble with these changes. This repo is already on the latest version of the tool. I don't see what would cause this unless the new library is bringing something in.

What is happening is that it is creating a bunch of stub not implemented methods in AzureFile. No idea why a tool that is suppose to only be formatting the code would generate all of that, I think it is triggering something else or an analyzer.

I'll make a PR to remove dotnet format.

[emgarten]

I removed dotnet format and confirmed this branch passes all functional tests on linux with that change.

I did some testing locally and everything is working well for me with Azure. The blob properties are showing up correctly so it looks like the default settings work fine.

Thanks for the work on this! 🏆