Fix hex_to_rgb extracting a hex from non hex strings #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a string had 3 or 6 valid ascii hex characters and one of those characters was the last character in the string the 'from_hex' function would return a valid hex. Returning an error if any invalid ascii hex is encountered in the string fixes this.
For example in the string 'Magenta' the hex extracted would be 'aea'.
Another one is 'DarkGray' being extracted as 'daa'.