Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to class #2

Open
emibcn opened this issue Oct 20, 2018 · 0 comments
Open

Convert to class #2

emibcn opened this issue Oct 20, 2018 · 0 comments
Assignees
@emibcn

Comments

@emibcn
Copy link
Owner

emibcn commented Oct 20, 2018 •
edited
Loading

Use real OOP instead of structural programming inside a class :/
@emibcn emibcn self-assigned this Oct 20, 2018
emibcn added a commit that referenced this issue Oct 28, 2018
@emibcn
Merge pull request #14 from emibcn/2-use-real-oop
9277b89 
WIP #2 - Use real OOP:
- Switch from distributed `exit()` & `print()` to `raise` own exceptions and only print on `main()` and exit if `__main__` or in `signal_handler`
- Move args to `Rac1` member, possibly assigned on instantiation
- Separate class method to allow easy command line player overriding
- Allow to change class used on main to allow easy overriding
- Better functions & methods naming
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Fix csome comments and strings
c87f982
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Add option to only print URL of filtered podcasts
b065bdf
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Marc some class members as private
1de5e67
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Add podcast data cache
435e36a
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Use internal date instead of taking it from parameter
e833895
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Discard parsing pages once all have been obtained
d46967c
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Simplify page data parser
60dbd90
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Use generators (x for x in whatever) and yield wherever …
f13a271 
…possible
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
Merge pull request #15 from emibcn/2-use-real-oop
017a17d 
WIP #2 - Use generators and some other improvements
- Fix some comments and strings
- Add option to only print URL of filtered podcasts
- Mark some class members as private
- Add podcast data cache
- Use internal date instead of taking it from parameter
- Discard parsing pages once all have been obtained
- Simplify page data parser
- Use generators `(x for x in whatever)` and `yield` wherever possible
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 & #7 - Add some logic from main to a new generator method, w…
e381130 
…hich:

- Cycles over downloaded and filtered podcasts
- Retries the list once finished listening (looking for new podcasts)
- Yields the podcasts that should be listened/printed
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Pop class method get_page and separate Rac1 class into 3 c…
a8f83ac 
…lasses:

- Rac1: Handles podcasts list
- PlayerCommand: Abstracts playing a podcast using a command
- MPlayerCommand: Plays a podcast using MPlayer command
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Fix some strings
c9426b6
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Separate class Rac1 into 2 classes:
723addc 
- Parser: Parses data from servers
- Filter: Filters parsed data from server with arguments and exposes the autoreloaded podcast generator
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
Merge pull request #16 from emibcn/2-use-real-oop
d7854db 
WIP #2 - Pop class method `get_page` and separate Rac1 class into 4 classes:
- Parser: Parses data from servers
- Filter: Filters parsed data from server with arguments and exposes the autoreloaded podcast generator
- PlayerCommand: Abstracts playing a podcast using a command
- MPlayerCommand: Plays a podcast using MPlayer command
emibcn added a commit that referenced this issue Nov 11, 2018
@emibcn
WIP #2 - Create class ParseArguments to proxy ConfigArgParse, using…
3c99d85 
… `__get_attr__` to serve ConfigArgParse results
emibcn added a commit that referenced this issue Nov 12, 2018
@emibcn
WIP #2 & #7 - Implement helpers:
0ae9211 
- Parser: caller method to easily get a date's UUIDs generator
- Filter: Generator methods to operate on parser's generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emibcn emibcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emibcn