Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterChain should pass the request and response from filters to Target function #482

Merged
merged 1 commit into from
Nov 24, 2021
Merged

FilterChain should pass the request and response from filters to Target function #482

merged 1 commit into from
Nov 24, 2021

Commits on Nov 24, 2021

  1. FilterChain should pass the request and response from filters to Targ… 

    …et function

The PR emicklei#478 brought some weird changes that breaks the filters behaviour.
We have a filter that creates another instance of Response to intercept all headers and data, then does an audit and modifies the data and only then it forwards to the original response.
But the lambda added in that PR breaks this logic, since the target function writes directly to the original response.
    Sergey Vilgelm committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    7ba50c4 View commit details
    Browse the repository at this point in the history