Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] Bad practice to have a mix of Receiver types. #491

Merged
merged 1 commit into from
Jun 4, 2022
Merged

[Minor] Bad practice to have a mix of Receiver types. #491

merged 1 commit into from
Jun 4, 2022

Commits on Apr 5, 2022

  1. [Minor] Bad practice to have a mix of Receiver types. 

    I was using an old version and saw that 
```
r.contentEncodingEnabled = &enabled
```
Fix was added, however String() should be updated to also use a pointer receiver.

Per Golang Docs "In general, all methods on a given type should have either value or pointer receivers, but not a mixture of both."
    @MushuEE
    MushuEE committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a05465f View commit details
    Browse the repository at this point in the history