Very basic support for Catch2 v3 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the official release of Catch2 v3.0.1 the header structure of that library has changed, and this breaks compatibility with anyone including
<rapidcheck/catch.h>, since it includes the old header.The fix I've added is to not do anything if the user has already included the new
<catch2/catch_test_macros.hpp>header. This should be compatible with any code that stays on v2.x versions of Catch2, and also compatible with anyone using the new major version of Catch2, with minor modifications, which they will have to make anyway when switching.This does not touch any of RapidCheck's tests. The reason for this is Catch2 v3 is a C++14 library, and RapidCheck is currently a C++11 library.
Another change this pull request makes is fix a test failure introduced by #290. It fixed an instance of undefined behaviour in the library, but didn't update a test to reflect this change. This means CI should pass again (fingers crossed).