Relationships with empty data, issue woohoolabs#20

* When `transformData` returns an empty data-set (null or and empty array) include this in the response. * The empty data for a ToManyRelationship is [] not null.
emil-nasso · Apr 28, 2016 · a6cb118 · a6cb118
1 parent 06c3b5e
commit a6cb118
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/JsonApi/Schema/Relationship/AbstractRelationship.php b/src/JsonApi/Schema/Relationship/AbstractRelationship.php
@@ -125,7 +125,7 @@ public function transform(
         ) {
             $transformedData = $this->transformData($transformation, $relationshipName, $defaultRelationships);
         } else {
-            $transformedData = null;
+            $transformedData = false;
         }
 
         if ($transformation->request->isIncludedField($resourceType, $relationshipName)) {
@@ -143,7 +143,7 @@ public function transform(
             }
 
             // DATA
-            if (isset($transformedData) === true) {
+            if ($transformedData !== false) {
                 $relationship["data"] = $transformedData;
             }
         }

diff --git a/src/JsonApi/Schema/Relationship/ToManyRelationship.php b/src/JsonApi/Schema/Relationship/ToManyRelationship.php
@@ -34,7 +34,7 @@ protected function transformData(
     ) {
         $data = $this->retrieveData();
         if (empty($data) || $this->resourceTransformer === null) {
-            return null;
+            return [];
         }
 
         $content = [];