Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging and other improvements #5

Merged
merged 16 commits into from
Oct 19, 2023
Merged

Logging and other improvements #5

merged 16 commits into from
Oct 19, 2023

Conversation

emilevr
Copy link
Owner

@emilevr emilevr commented Oct 19, 2023

Describe your changes

  • Added a log file for warnings and errors.
  • Added a --show-timing arg that shows the time it took to analyze and display the non-interactive output.
  • Removed indirect dependency on crate atty.
  • Various minor improvements.
  • Improved code coverage.

PR requirements

  • I have followed the guidelines in the Contribution Guide document.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • I have confirmed locally that there are no linting issues.
  • I have confirmed that all tests pass locally.
  • I have confirmed that my changes do not negatively impact performance by manually comparing before and
    after performance against a suitable local directory tree.
  • I have confirmed that code coverage has not regressed as a result of my changes.

Emile van Reenen added 13 commits October 17, 2023 21:04
@emilevr emilevr changed the title Feat/emilevr/logging Logging and other improvements Oct 19, 2023
@emilevr emilevr merged commit 847987d into main Oct 19, 2023
10 checks passed
@emilevr emilevr deleted the feat/emilevr/logging branch October 19, 2023 07:13
emilevr added a commit that referenced this pull request Oct 27, 2023
@emilevr
Logging and other improvements (#5)
e203f66 
* Update bug report template
* Update contribution guide
* Use a different target dir when running code coverage to not break incremental builds
* Remove atty dependency in buildit by disabling default clap feature
* Add different target dir for coverage builds to play nice with incremental builds
* Improve code coverage of view_command module
* Change logging impl to log4rs and add tests
* Update contribution guide and add a PR template
* Add pre-commit hooks for BuildIt
* Update PR template
* Add --show-timings arg. Minor refactor of size display format arg usage. Improve code coverage
* Enable coverage workflow for PRs
* Fix unused import warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@emilevr