Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responders dependency #1

Merged
merged 1 commit into from May 29, 2015
Merged

Responders dependency #1

merged 1 commit into from May 29, 2015

Conversation

dfreerksen
Copy link
Contributor

Responders should be a dependency if it is being used. Don't rely on the application to add a dependency that is required by the gem.

Without adding this gem as a dependency and without it being part of your application, you will get an error saying

The controller-level `respond_to' feature has been extracted to the `responders` gem. Add it to your Gemfile to continue using this feature: gem 'responders', '~> 2.0' Consult the Rails upgrade guide for details.

@emilioforrer
Copy link
Owner

Thanks for your contribution :)

The problem to add this dependency is that that it make the gem version incompatible with rails 3.2, but i guess it's time to release a major version (2.0.0) for rails 4.2+.

Sorry for the delay in my response. Thanks for the merge request, you will see the change in version 2.

emilioforrer added a commit that referenced this pull request May 29, 2015
@emilioforrer emilioforrer merged commit 6801712 into emilioforrer:master May 29, 2015
@dfreerksen dfreerksen mentioned this pull request May 29, 2015
Open
@dfreerksen dfreerksen deleted the responders branch June 3, 2015 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants