How do I change taskbar icon?

[0xDema]

I have done a bit of a search on google and here. I am trying to customize the icon I am using in the desktop application I made using egui. This includes all 3 places where it can usually be seen.

1. The taskbar
2. The exe file
3. The top left of the program.

For the 2nd I had to use winres and it was unrelated to egui but I found some old discussions on how to do that.
For the 3rd I found another discussion
However for the 1st place, the actual windows taskbar, I still get an egui icon and was wondering how I could change that. I expected it to match the icon at the top left of the program (The 3rd) I also do recognize that it mentions that these fixes only work for Windows but I'll tackle mac and linux further down the line. Is there another way to change the taskbar? The code I changed matches what the 2 discussions above use.

[emilk]

The best way to set an icon in frame is to set an icon for NativeOptions::viewport. I'm not sure exactly how well it works on different platforms though.

[0xDema]

Perhaps I have it implemented incorrectly but I was following the steps on that, the icon at the top left in the frame is my custom icon. But on the windows taskbar it still is not. Is it meant to change both or is there another step I need to take for the taskbar?

[emilk]

Here is the code that does the work:

egui/crates/eframe/src/native/app_icon.rs

Lines 78 to 99 in a5973e5

	/// Set icon for Windows applications.
	#[cfg(target_os = "windows")]
	#[allow(unsafe_code)]
	fn set_app_icon_windows(icon_data: &IconData) -> AppIconStatus {
	use crate::icon_data::IconDataExt as _;
	use winapi::um::winuser;
	// We would get fairly far already with winit's `set_window_icon` (which is exposed to eframe) actually!
	// However, it only sets ICON_SMALL, i.e. doesn't allow us to set a higher resolution icon for the task bar.
	// Also, there is scaling issues, detailed below.
	// TODO(andreas): This does not set the task bar icon for when our application is started from python.
	// Things tried so far:
	// * Querying for an owning window and setting icon there (there doesn't seem to be an owning window)
	// * using undocumented SetConsoleIcon method (successfully queried via GetProcAddress)
	// SAFETY: WinApi function without side-effects.
	let window_handle = unsafe { winuser::GetActiveWindow() };
	if window_handle.is_null() {
	// The Window isn't available yet. Try again later!
	return AppIconStatus::NotSetTryAgain;
	}

Feel free to dig into it and improve it :)