-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing forbid unsafe_code attributes #2723
Comments
Good catch! I've removed the misleading badges. As for parsing correctly with |
Sure, I'll try to have a look at it this weekend. As far as I can tell, this is the line that prevents unsafe code: Line 4 in f94187a
But it isn't part of the crate source and is only used during CI, so geiger doesn't see it. So it should only be a matter of adding the attribute to the crates that don't have unsafe. |
Some crates have the safety dance badge in their individual README files, but none of them have the required
#![forbid(unsafe_code)]
attribute. Indeed, some of them display the badge even though they actually have unsafe code, namely eframe and egui-winit, which is misleading. The badge should be removed from crates that have unsafe code, and those that don't should have the attribute so they are parsed correctly by cargo-geiger.The text was updated successfully, but these errors were encountered: