Update resvg dependency of egui_extras
#3652
Labels
dependencies
Pull requests that update a dependency file
egui_extras
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
emilk
added
help wanted
Merged
emilk
pushed a commit
that referenced
this issue
Dec 20, 2023
Update `resvg` from v0.28 to v0.37. Remove related, unnecessary entries from `deny.toml`. ⚠ In example `images` ferris is scaled differently, but I guess that now it scales in expected way (takes all available space; before this PR it takes up to space that, was available at first render- it does not upscale). This PR is minimal adaptation to new `resvg` api and small related simplification, however it should be considered to update loaders (currently if svg image initially was small and was scaled up it will be blurred, see #3501). As svg image now scales over render size, problem will be more often seen now. (currently `SvgLoader` theoretically should rerender for different sizes (but I guess it will result in memory leak in that case), but refreshing is stopped earlier in `DefaultTextureLoader`). I have initial version of loaders update, that will fix issue with svg scaling (and also enable e.g. reloading image if file has been changed), I will submit these changes in separate PR once this one is merged. Closes <#3652>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It is getting old
The text was updated successfully, but these errors were encountered: