Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epaint::text::Fonts should be Clone #3731

Closed
Aurel300 opened this issue Dec 23, 2023 · 0 comments · Fixed by #3737
Closed

epaint::text::Fonts should be Clone #3731

Aurel300 opened this issue Dec 23, 2023 · 0 comments · Fixed by #3737
Labels
bug Something is broken

Comments

@Aurel300
Copy link

The description for Fonts says:

Create one and reuse. Cheap to clone.

However, there is no Clone implementation (and the struct contents are private). Since this is just a wrapper for Arc, I assume the intention was to just derive Clone.
@Aurel300 Aurel300 added the bug Something is broken label Dec 23, 2023
emilk added a commit that referenced this issue Dec 25, 2023
@emilk
impl Clone for Fonts
178e4a3 
Closes #3731
@emilk emilk mentioned this issue Dec 25, 2023
Merged
emilk added a commit that referenced this issue Dec 25, 2023
@emilk
impl Clone for Fonts (#3737)
0a6ea15 
Closes #3731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

impl Clone for Fonts emilk/egui
1 participant
@Aurel300