Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu: sub-menu don't disappear when hovering another, non-sub-menu item #4101

Closed
abey79 opened this issue Feb 26, 2024 · 2 comments · Fixed by #4166
Closed

Context menu: sub-menu don't disappear when hovering another, non-sub-menu item #4101

abey79 opened this issue Feb 26, 2024 · 2 comments · Fixed by #4166
Assignees
@emilk
Labels
bug Something is broken egui

Comments

@abey79
Copy link
Collaborator

abey79 commented Feb 26, 2024

*** Repro

On https://egui.rs as of today:

bug_contex_menu.mp4
@abey79 abey79 added bug Something is broken egui labels Feb 26, 2024
@emilk
Copy link
Owner

emilk commented Feb 26, 2024

Probably related to #3055

@abey79 abey79 mentioned this issue Feb 27, 2024
Closed
@abey79
Copy link
Collaborator Author

abey79 commented Mar 5, 2024

Probably related to #3055

Very likely, in the sense that PR removed all conditions for closing the current menu. Rightfully so, as before the submenu wasn't sticky enough. But now we need to re-introduce one closing condition. Formally, we must close sub-menu N+1 whenever any widget from sub-men N is hovered. I tried to take a look at the code, but I'm really unsure how to proceed.

@emilk emilk mentioned this issue Mar 12, 2024
Closed
@emilk emilk self-assigned this Mar 13, 2024
@emilk emilk mentioned this issue Mar 13, 2024
Merged
emilk added a commit that referenced this issue Mar 13, 2024
@emilk
Improve logic for when submenus are kept open (#4166)
0afbefc 
* Closes #2853
* Closes #4101
* Reverts parts of #3055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
bug Something is broken egui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve logic for when submenus are kept open emilk/egui
2 participants
@emilk @abey79