Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything is super dark in epiphany #794

Closed
Barugon opened this issue Oct 13, 2021 · 14 comments
Closed

Everything is super dark in epiphany #794

Barugon opened this issue Oct 13, 2021 · 14 comments
Labels
bug Something is broken web Related to running Egui on the web

Comments

@Barugon
Copy link
Contributor

Barugon commented Oct 13, 2021

Describe the bug
The demo web app is super dark in epiphany. See screenshot below.

To Reproduce
Steps to reproduce the behavior:

  1. Open the demo web app in epiphany.

Expected behavior
Should look like it does in other web browsers (e.g. Firefox).

Screenshots
Screenshot from 2021-10-13 10-49-04

Desktop (please complete the following information):

  • OS: Fedora 34
  • Browser: Epiphany
  • Version: 40.3
@Barugon Barugon added the bug Something is broken label Oct 13, 2021
@KentaTheBugMaker
Copy link
Contributor

It seems to me using wrong surface format.
It occurs when surface format is not SRGB.

@Barugon
Copy link
Contributor Author

Barugon commented Oct 14, 2021

Maybe linear RGB?

@emilk emilk added the web Related to running Egui on the web label Oct 14, 2021
@KentaTheBugMaker
Copy link
Contributor

when i wrote vulkano backend it suffers color glitch on UNORM not on SRGB .
maybe your web backend painter is WebGL1?

@KentaTheBugMaker
Copy link
Contributor

I tested webgl 1 with Srgb Texture support .
It does not color glitch.
your browser maybe don't support Srgb texture.

@KentaTheBugMaker
Copy link
Contributor

you need to test your browser and hardware by accessing to below.
https://webglreport.com/
and write your hardware.

@Barugon
Copy link
Contributor Author

Barugon commented Oct 14, 2021

Here's the result. WebGL 2 is not supported.

Screenshot from 2021-10-14 11-58-23

@KentaTheBugMaker
Copy link
Contributor

this site don't report GPU name correctly so we must determine your hardware more.
it show me EXT_sRGB is supported but bad result maybe crappy WebGL implementation?

@Barugon
Copy link
Contributor Author

Barugon commented Oct 15, 2021

It's a Radeon RX 5700 XT using the open source drivers.

@KentaTheBugMaker
Copy link
Contributor

I think webkitGTK problem not egui or gfx driver.
or other gpu on your system selected?

@Barugon
Copy link
Contributor Author

Barugon commented Oct 15, 2021

No other GPU.

@KentaTheBugMaker
Copy link
Contributor

servo does not support webGL2 and EXT_sRGB but render it correctly.
I think webkitGTK present EXT_sRGB but actual frame buffer is not sRGB
スクリーンショット 2021-10-15 130355
スクリーンショット 2021-10-15 130820
.

@emilk
Copy link
Owner

emilk commented Oct 24, 2021

Perhaps we can use navigator.userAgent to special-case epiphany in the srgb_supported check in https://github.com/emilk/egui/blob/master/egui_web/src/webgl1.rs#L65 ?

@KentaTheBugMaker
Copy link
Contributor

I fixed it by reapply sRGB correcting in post process
I will make PR to fix this problem.

@KentaTheBugMaker
Copy link
Contributor

I found midori also have this issue.
so I generalized to WebKitGTK.

@emilk emilk closed this as completed in 008a971 Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken web Related to running Egui on the web
Projects
None yet
Development

No branches or pull requests

3 participants